Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating fragments from CLI args with kind choices #676

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix creating fragments from CLI args with kind choices #676

merged 2 commits into from
Jun 25, 2024

Conversation

miniscruff
Copy link
Owner

Closes #675

Check the following

  • Maintain high code coverage
  • Be properly formatted
  • Documentation changes are included
  • Include a change file if expected

@miniscruff
Fix issue with creating fragments entirely from CLI args
b07283b 
* Related to using a kind config with custom choices
if you were to include the custom values in CLI args they were mistaken
for invalid choices.
@miniscruff miniscruff linked an issue Jun 25, 2024 that may be closed by this pull request
Creating a new fragment entirely via CLI args fails if there are custom prompts for the kind selected #675
Closed
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3fc28b71 ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3fc28b7) Report Missing Report Missing Report Missing
Head commit (dc9155e) 2446 2281 93.25%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#676) 16 16 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@miniscruff miniscruff merged commit e3893fc into main Jun 25, 2024
5 checks passed
@miniscruff miniscruff deleted the 675-creating-a-new-fragment-entirely-via-cli-args-fails-if-there-are-custom-prompts-for-the-kind-selected branch June 25, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a new fragment entirely via CLI args fails if there are custom prompts for the kind selected
1 participant
@miniscruff